Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: replace deprecated throwError usage #3733

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

markonyango
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3702

What is the new behavior?

Packages are compatible with RxJs version 6 again.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Dec 30, 2022

Deploy Preview for ngrx-io-v14 canceled.

Name Link
🔨 Latest commit 42924c9
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io-v14/deploys/63b59a84ffb07000081b5954

@netlify
Copy link

netlify bot commented Dec 30, 2022

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 42924c9
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63b59a84a5d0240009dd2db0

@markonyango
Copy link
Author

I am not sure what "Labeler" is supposed to do. Anything on my part?

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @markonyango

Thanks for creating this PR!

There is no need to revert throwError usages in spec files and example apps because the ngrx/platform repo uses RxJS 7. Can you please take a look at this PR, and apply the same changes? It would also be good if you could split the changes from data and component-store packages into separate commits.

@markonyango
Copy link
Author

Am I allowed to force commit new commits into this PR overwriting this one? That would be cleaner imo then adding new commits, no?

@markostanimirovic
Copy link
Member

Am I allowed to force commit new commits into this PR overwriting this one? That would be cleaner imo then adding new commits, no?

Yes! Feel free to force update this PR.

@markonyango
Copy link
Author

markonyango commented Jan 4, 2023

Don't merge yet, git somehow screwed with my changes...Will clean it up immediately.

EDIT: Successfully rebased the PR. It should now resemble the commits to v15.

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markonyango!

@markostanimirovic markostanimirovic merged commit 3d31996 into ngrx:14.3.x Jan 4, 2023
@markonyango markonyango deleted the 14.3.x branch January 5, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants