Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce @ngrx/operators package #4097

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Oct 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4057

What is the new behavior?

Introduces new @ngrx/operators package for the following operators to be shared across NgRx packages

  • tapResponse from @ngrx/component-store
  • concatLatestFrom from @ngrx/effects

The @ngrx/operators package will be added to these packages as a dependency, and the operators will be re-exported to prevent any breaking changes.

The @ngrx/operators package can also be installed as a standalone dependency.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 152c432
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/653a64d6ae349300078570e2

@brandonroberts brandonroberts marked this pull request as ready for review October 25, 2023 02:14
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks Brandon!
Should operators also be added to publish-latest and publish-next?

@brandonroberts
Copy link
Member Author

🚀 Thanks Brandon! Should operators also be added to publish-latest and publish-next?

Good catch. Added signals and operators

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Brandon! 🥇

modules/operators/package.json Outdated Show resolved Hide resolved
modules/operators/public_api.ts Outdated Show resolved Hide resolved
build/publish-latest.ts Show resolved Hide resolved
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@markostanimirovic markostanimirovic merged commit e93ead4 into main Oct 26, 2023
5 checks passed
@markostanimirovic markostanimirovic deleted the feat-ngrx-operators branch October 26, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add @ngrx/operators package
3 participants