-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard: Add onboard virtual keyboard to scarthgap #732
base: nilrt/master/next
Are you sure you want to change the base?
Conversation
43b7c6c
to
6c2a2de
Compare
@pratheekshasn you mentioned offline that there were issues getting onboard work on cRIO and some segfault issue; have they been addressed? Is this really ready for review? |
The cRIO issue can be solved by tweaking a couple of values in onboard-settings, so yes, this is ready for review. Here are the similarities and differences between kirkstone and scarthgap for onboard:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commits look good now; thanks. Just squash them down into a single commit for the pull.
What is your intention with regards to upstreaming the recipe fixes? Are you trying to upstream the meta-OE PR with yocto first?
Can you describe what these settings are? Are these settings part of this PR? |
I'm a little confused here; you mention that for scarthgap the setting is False. But in
which seems to imply that the setting is true. This file is also exactly the same as kirkstone's. Does that mean that despite the same settings as kirkstone onboard works differently on scarthgap and ignores these settings? Or am I misunderstanding? |
Sorry about the confusion, the default value of When we set the value through the command line (via Furthermore, we suspect that the mousetweaks warning that gets thrown might be preventing onboard from launching immediately (like in kirkstone).
I think we can still go ahead and submit this PR that makes the onboard keyboard at least appear, albeit with a workaround. For the issue of it not showing up on a cRIO target when it can still show up in a VM, it can be fixed as a separate work item. What are your thoughts, @chaitu236? |
80ba5c9
to
d450ae7
Compare
If you mean launching
Launching onboard process from terminal is just a debugging step we used to figure out why the keyboard wasn't appearing; if everything works correctly, we shouldn't have to launch it from terminal so we don't need to care about this difference except for debugging purposes.
We do need to find a fix for this before we submit/upstream as we do want the keyboard to appear without user intervention or workarounds (like in kirkstone).
Like we discussed, it'd be better to identify the correct fix as we're not in a rush to add this package back. |
4580f6f
to
1964c4a
Compare
1964c4a
to
fbd2117
Compare
6d1e9da
to
a695f3d
Compare
d18c0a4
to
9a7ba57
Compare
Summary of Changes
The PR adds the virtual keyboard "Onboard" to scarthgap.
Justification
#AB2491688 requires the keyboard to be present on scarthgap as well.
The virtual keyboard "Onboard" (present on kirkstone) had been removed from scarthgap due to build errors on python 3.12. This PR adds back the same to scarthgap with corrections required for python3.12.
Implementation
Changes that differ from kirkstone:
-Werror=declaration-after-statement
to remove build errors that get generated when the recipe builds the source of Onboard.distutils3
gets changed tosetuptools3
.setuptools3
installs files to the site-packages folder no matter what absolute path is specified as the prefix for the installation path.Other required changes can be seen in this PR in the meta-openembedded layer.
The keyboard can now be launched and used just like in kirkstone.
Testing
bitbake packagefeed-ni-core
)Tested by installing the built IPK on a VM.
Signed-off by: Pratheeksha S N [email protected]