Leverage appropriate number format options in number-text table column once supported in all browsers #1442
Comments
1 task
mollykreis
changed the title
m-akinc
added
blocked
|
Should check on this again in early 2024 |
|
@m-akinc please wait to address this till after the unit support is merged |
1 task
|
Waiting for a Chromatic update to get new enough browsers to support these options. Could be any time now. |
rajsite
pushed a commit
that referenced
this issue
Feb 26, 2024
# Pull Request ## 🤨 Rationale Fixes: #1442 ## 👩💻 Implementation The options cited in the issue are: - `useGrouping: 'auto'` - We previously were setting this to `true`, which means "display grouping separators even if the locale prefers otherwise." Instead we want `"auto"`, which is "display grouping separators based on the locale preference." The default for this option is `"auto"` unless `notation` is `"compact"`. We never set `notation` to `"compact"`, so we can just leave `useGrouping` to use the default. - `signDisplay: 'negative'` - Though this option value has been [supported in all browsers since 8/23](https://caniuse.com/mdn-javascript_builtins_intl_numberformat_numberformat_options_signdisplay_parameter_negative), there does not seem to be a version of Typescript whose definition of `Intl.NumberFormatOptions` allows it. There is an [open issue for adding support](microsoft/TypeScript#56269). As a workaround, I've just added type assertions where necessary. - `roundingPriority: 'lessPrecision'` - Just like `signDisplay: 'negative'`, the `roundingPriority` option has been [supported in browsers since 8/23](https://caniuse.com/mdn-javascript_builtins_intl_numberformat_numberformat_options_roundingpriority_parameter), but Typescript doesn't have support yet. It is tracked by the same issue linked above, and our type assertion serves as a workaround for this, too. By using this option, we can get rid of the separate `leadingZeroFormatter` in `DefaultUnitFormat` and simplify the logic. ## 🧪 Testing Existing tests pass. ## ✅ Checklist - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🧹 Tech Debt
As part of #1414, we had to make some concessions and add some work-arounds due to certain number format options not being supported yet in Firefox.
Once Firefox has parity support with other browsers for these options for at least 6 months we should update our numeric formatters for the number-text table column to use these features.
Specifically the options we would like to use but cannot yet are:
useGrouping: autosignDisplay: negativeroundingPriority: 'lessPrecision'The text was updated successfully, but these errors were encountered: