Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python3 setup when system encoding is not utf-8 #120

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Fix python3 setup when system encoding is not utf-8 #120

merged 1 commit into from
Nov 18, 2017

Conversation

gaetano-guerriero
Copy link
Contributor

Under python3, opening utf-8 files like HISTORY.rst in setup.py causes encoding
error if the default encoding for the system is not utf-8.

This happens for instance on debian reproducible builds where environment has LC_ALL=C

@gaetano-guerriero
Fix python3 setup when system encoding is not utf-8
a0ac1fd 
Under python3, opening utf-8 files like HISTORY.rst in setup.py causes encoding
error if the default encoding for the system is not utf-8.
@coveralls
Copy link

coveralls commented Nov 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 70.544% when pulling a0ac1fd on gaetano-guerriero:fix-py3-setup-with-non-utf8-default-encoding into 21de03a on nicfit:master.

@nicfit
Copy link
Owner

nicfit commented Nov 18, 2017

Thanks!

@nicfit nicfit merged commit b716732 into nicfit:master Nov 18, 2017
nicfit added a commit that referenced this pull request Nov 18, 2017
@nicfit
Merge branch 'master' of github.com:nicfit/eyeD3
70706ff 
* 'master' of github.com:nicfit/eyeD3:
  fix: Fix python3 setup when system encoding is not utf-8 (#120)
nicfit added a commit that referenced this pull request Nov 18, 2017
@nicfit
Merge branch 'master' into devel
c9dbe0b 
* master:
  release prep  !wip
  fix: [display plugin] Handle comments
  new: Composer (TCOM) support (#123)
  chg: More forgiving of invalid text encoding identifiers (fixes #101)
  chg: More forgiving of bad Unicode in text frames (fixes #105)
  version bump. !wip
  fix: Fix python3 setup when system encoding is not utf-8 (#120)
  Update pytest from 3.2.4 to 3.2.5 (#122)
  Update pytest from 3.2.3 to 3.2.4 (#121)
  chg: eyeD3 cmd line helper turned nto session-scoped fixture
  Set theme jekyll-theme-slate
  fix: Help pymagic with poorly encoded filenames
nicfit added a commit that referenced this pull request Mar 10, 2018
@nicfit
Squashed commit of the following:
76e4f6a 
commit f877ae4
Merge: da02459 bc16a97
Author: Travis Shirk <[email protected]>
Date:   Sat Mar 10 08:28:39 2018 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update twine from 1.9.1 to 1.10.0 (#168)
      Update pytest from 3.4.1 to 3.4.2 (#167)

commit bc16a97
Author: pyup.io bot <[email protected]>
Date:   Thu Mar 8 00:29:28 2018 +0100

    Update twine from 1.9.1 to 1.10.0 (#168)

commit 257d238
Author: pyup.io bot <[email protected]>
Date:   Tue Mar 6 17:19:09 2018 +0100

    Update pytest from 3.4.1 to 3.4.2 (#167)

commit da02459
Author: Travis Shirk <[email protected]>
Date:   Sat Mar 3 22:44:48 2018 -0700

    Clean pytest_cache

commit cfa2c63
Merge: 10a3436 fba3d67
Author: Travis Shirk <[email protected]>
Date:   Sun Feb 25 22:16:52 2018 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update index.rst (#164)
      Update pytest from 3.4.0 to 3.4.1 (#162)
      Update sphinx from 1.7.0 to 1.7.1 (#163)

commit 10a3436
Author: Travis Shirk <[email protected]>
Date:   Sun Feb 25 22:16:19 2018 -0700

    cleanup  !wip

commit fba3d67
Author: Deoren Moor <[email protected]>
Date:   Sun Feb 25 13:13:30 2018 -0600

    Update index.rst (#164)

    GitHub hosts Git repos, so update DVCS name to reflect that.

commit 9361db9
Author: pyup.io bot <[email protected]>
Date:   Sat Feb 24 19:55:08 2018 +0100

    Update pytest from 3.4.0 to 3.4.1 (#162)

commit e8d378a
Author: pyup.io bot <[email protected]>
Date:   Sat Feb 24 19:54:55 2018 +0100

    Update sphinx from 1.7.0 to 1.7.1 (#163)

commit 9098853
Author: Travis Shirk <[email protected]>
Date:   Sun Feb 18 15:10:19 2018 -0700

    nicfit.py cc update

commit 8891167
Author: pyup.io bot <[email protected]>
Date:   Sun Feb 18 22:36:40 2018 +0100

    Update nicfit.py from 0.7 to 0.8 (#161)

commit cb8345b
Author: pyup.io bot <[email protected]>
Date:   Fri Feb 16 07:09:51 2018 +0100

    Update ipdb from 0.10.3 to 0.11 (#159)

commit 95fd207
Author: pyup.io bot <[email protected]>
Date:   Mon Feb 12 18:55:02 2018 +0100

    Update sphinx from 1.6.7 to 1.7.0 (#158)

commit 244c21f
Author: pyup.io bot <[email protected]>
Date:   Sun Feb 11 17:26:38 2018 +0100

    Update pytest-runner from 3.0 to 4.0 (#157)

commit ff03e03
Merge: 1b22d87 af7b263
Author: Travis Shirk <[email protected]>
Date:   Thu Feb 8 16:42:21 2018 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update sphinx from 1.6.6 to 1.6.7 (#154)

commit 1b22d87
Author: Travis Shirk <[email protected]>
Date:   Thu Feb 8 16:41:49 2018 -0700

    Added docs for install devel dependencies and test data.

commit af7b263
Author: pyup.io bot <[email protected]>
Date:   Mon Feb 5 23:16:40 2018 +0100

    Update sphinx from 1.6.6 to 1.6.7 (#154)

commit d685c21
Author: pyup.io bot <[email protected]>
Date:   Thu Feb 1 04:35:02 2018 +0100

    Update pytest from 3.3.2 to 3.4.0 (#152)

commit ed3c215
Author: pyup.io bot <[email protected]>
Date:   Mon Jan 29 03:00:44 2018 +0100

    Update factory-boy from 2.9.2 to 2.10.0 (#150)

commit 62a1229
Author: pyup.io bot <[email protected]>
Date:   Fri Jan 12 23:31:07 2018 +0100

    Update sphinx from 1.6.5 to 1.6.6 (#148)

commit 06601be
Author: pyup.io bot <[email protected]>
Date:   Fri Jan 5 17:20:38 2018 +0100

    Update pytest from 3.3.1 to 3.3.2 (#147)

commit 04766bd
Merge: dc64168 99f3b61
Author: Travis Shirk <[email protected]>
Date:   Wed Jan 3 17:00:08 2018 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update pyaml from 17.10.0 to 17.12.1 (#138)

commit dc64168
Author: Travis Shirk <[email protected]>
Date:   Wed Jan 3 16:58:56 2018 -0700

    chg: Removed paver as a dep

commit 99f3b61
Author: pyup.io bot <[email protected]>
Date:   Sat Dec 30 04:36:13 2017 +0100

    Update pyaml from 17.10.0 to 17.12.1 (#138)

commit 25c4db7
Merge: 5e0783c bd1d174
Author: Travis Shirk <[email protected]>
Date:   Fri Dec 15 20:27:00 2017 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update python-magic to 0.4.15 (#130)
      Update pip-tools from 1.10.2 to 1.11.0 (#129)
      Update pytest from 3.3.0 to 3.3.1 (#131)
      Update pytest from 3.2.5 to 3.3.0 (#128)
      Update sphinx-issues from 0.3.1 to 0.4.0 (#127)

commit 5e0783c
Author: Travis Shirk <[email protected]>
Date:   Fri Dec 15 20:26:16 2017 -0700

    chg: removed fabfile and mkenv

commit bd1d174
Author: pyup.io bot <[email protected]>
Date:   Tue Dec 12 05:32:42 2017 +0100

    Update python-magic to 0.4.15 (#130)

    * Update python-magic from 0.4.13 to 0.4.15

    * Update python-magic from 0.4.13 to 0.4.15

commit 0abe2e8
Author: pyup.io bot <[email protected]>
Date:   Fri Dec 8 16:38:37 2017 +0100

    Update pip-tools from 1.10.2 to 1.11.0 (#129)

commit 89a42f4
Author: pyup.io bot <[email protected]>
Date:   Thu Dec 7 00:45:03 2017 +0100

    Update pytest from 3.3.0 to 3.3.1 (#131)

commit 41b6a84
Author: pyup.io bot <[email protected]>
Date:   Tue Nov 28 05:24:44 2017 +0100

    Update pytest from 3.2.5 to 3.3.0 (#128)

commit af9ada2
Author: pyup.io bot <[email protected]>
Date:   Tue Nov 28 05:06:40 2017 +0100

    Update sphinx-issues from 0.3.1 to 0.4.0 (#127)

commit 76eca97
Author: pyup.io bot <[email protected]>
Date:   Thu Nov 23 20:51:23 2017 +0100

    Update pip-tools from 1.10.1 to 1.10.2 (#126)

commit 457f88f
Author: pyup.io bot <[email protected]>
Date:   Wed Nov 22 01:52:21 2017 +0100

    Update check-manifest from 0.35 to 0.36 (#125)

commit 308305e
Author: Travis Shirk <[email protected]>
Date:   Sun Nov 19 21:41:49 2017 -0700

    pep8  !wip

commit 3b1404a
Merge: 7834abb 68b6201
Author: Travis Shirk <[email protected]>
Date:   Sun Nov 19 20:37:40 2017 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update nicfit.py from 0.6.6 to 0.7 (#124)

commit 7834abb
Author: Travis Shirk <[email protected]>
Date:   Sun Nov 19 20:36:32 2017 -0700

    new: eyed3.core.EP_MAX_SIZE_HINT

commit 68b6201
Author: pyup.io bot <[email protected]>
Date:   Mon Nov 20 01:22:26 2017 +0100

    Update nicfit.py from 0.6.6 to 0.7 (#124)

commit 0c8be9e
Author: Travis Shirk <[email protected]>
Date:   Sun Nov 19 12:33:01 2017 -0700

    [stats plugin] Skip None when sorting names.

commit 762a0f4
Author: Travis Shirk <[email protected]>
Date:   Sun Nov 19 12:31:11 2017 -0700

    chg: Similarly to TextFrame, fallback to latin1 for invalid encodings

commit f0d5bf6
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 17 20:43:04 2017 -0700

    release prep  !wip

commit 2d70df4
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 17 20:20:23 2017 -0700

    fix: [display plugin] Handle comments

commit c12425c
Author: nicfit <[email protected]>
Date:   Fri Nov 17 20:10:34 2017 -0700

    new: Composer (TCOM) support (#123)

commit 3094a8a
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 17 20:05:15 2017 -0700

    chg: More forgiving of invalid text encoding identifiers (fixes #101)

commit ed215f3
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 17 19:37:32 2017 -0700

    chg: More forgiving of bad Unicode in text frames (fixes #105)

commit 70706ff
Merge: b0c3325 b716732
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 17 19:29:01 2017 -0700

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      fix: Fix python3 setup when system encoding is not utf-8 (#120)

commit b0c3325
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 17 18:07:01 2017 -0700

    version bump. !wip

commit b716732
Author: gaetano-guerriero <[email protected]>
Date:   Sat Nov 18 02:05:56 2017 +0100

    fix: Fix python3 setup when system encoding is not utf-8 (#120)

    Under python3, opening utf-8 files like HISTORY.rst in setup.py causes encoding
    error if the default encoding for the system is not utf-8.

commit d729dc4
Author: pyup.io bot <[email protected]>
Date:   Wed Nov 15 18:22:50 2017 +0100

    Update pytest from 3.2.4 to 3.2.5 (#122)

commit b73d7a0
Author: pyup.io bot <[email protected]>
Date:   Wed Nov 15 18:22:07 2017 +0100

    Update pytest from 3.2.3 to 3.2.4 (#121)

commit 21de03a
Merge: 62f16fb cc4c601
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 20:51:01 2017 -0600

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Set theme jekyll-theme-slate

commit 62f16fb
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 20:50:04 2017 -0600

    chg: eyeD3 cmd line helper turned nto session-scoped fixture

commit cc4c601
Author: nicfit <[email protected]>
Date:   Sat Nov 4 20:06:38 2017 -0600

    Set theme jekyll-theme-slate

commit 7ffef22
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 18:55:15 2017 -0600

    fix: Help pymagic with poorly encoded filenames

commit d7f1711
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 14:14:50 2017 -0600

    new: Check for version incompatibilities during setter, and slight refactor.

commit d635846
Merge: 32c3551 32d9a61
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 10:43:32 2017 -0600

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      pep8 !wip

commit 32c3551
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 10:25:33 2017 -0600

    fix: [display plugin] Handle internal exception types. Fixes #118

commit 87f80df
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 10:15:45 2017 -0600

    chg: Only warn about missing grako when the plugin is used. Fixes #115

commit 32d9a61
Merge: 73c613c 54b4735
Author: Travis Shirk <[email protected]>
Date:   Sat Nov 4 08:39:47 2017 -0600

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      fix: IOError (nor OSError) have a message attr.
      Fix bad frames detection in stats plugin for python3 (#113)
      script exits with 0 status when called with --version/--help (#109)
      Update pytest-runner from 2.12.1 to 3.0 (#108)
      Update sphinx from 1.6.4 to 1.6.5 (#106)
      Update flake8 from 3.4.1 to 3.5.0 (#107)
      Release prep.  !wip
      fix: Reload and process after tag removals, fixes #102. (PR #103)
      pep doc strings.  !wip
      Update nicfit.py from 0.6.5 to 0.6.6 (#100)
      Update pyaml from 17.8.0 to 17.10.0 (#99)

commit 54b4735
Author: Travis Shirk <[email protected]>
Date:   Fri Nov 3 18:46:13 2017 -0600

    fix: IOError (nor OSError) have a message attr.

commit f1d7160
Author: gaetano-guerriero <[email protected]>
Date:   Wed Nov 1 00:35:23 2017 +0100

    Fix bad frames detection in stats plugin for python3 (#113)

    Comparison of string vs binary string was preventing detection of private frames
    in stats plugin.

commit 6916b24
Author: gaetano-guerriero <[email protected]>
Date:   Wed Nov 1 00:23:56 2017 +0100

    script exits with 0 status when called with --version/--help (#109)

    finally clause in _main() function was blocking argparse behaviour of exiting
    with 0 status code when those options are used.

commit 19e29cd
Author: pyup.io bot <[email protected]>
Date:   Sun Oct 29 18:45:03 2017 +0100

    Update pytest-runner from 2.12.1 to 3.0 (#108)

commit 2abec50
Author: pyup.io bot <[email protected]>
Date:   Thu Oct 26 17:12:40 2017 +0200

    Update sphinx from 1.6.4 to 1.6.5 (#106)

commit c91d4db
Author: pyup.io bot <[email protected]>
Date:   Thu Oct 26 17:12:21 2017 +0200

    Update flake8 from 3.4.1 to 3.5.0 (#107)

commit 73c613c
Merge: 7cb06a8 24a6888
Author: Travis Shirk <[email protected]>
Date:   Mon Oct 9 00:07:43 2017 -0600

    Merge branch 'master' of github.com:nicfit/eyeD3

    * 'master' of github.com:nicfit/eyeD3:
      Update pytest from 3.2.2 to 3.2.3 (#98)
      Update tox from 2.9.0 to 2.9.1 (#97)
      Update tox from 2.8.2 to 2.9.0 (#96)
      Update pip-tools from 1.9.0 to 1.10.1 (#95)
      Update sphinx from 1.6.3 to 1.6.4 (#93)

commit 7cb06a8
Author: Travis Shirk <[email protected]>
Date:   Mon Oct 9 00:07:09 2017 -0600

    pep8 !wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaetano-guerriero @coveralls @nicfit