fix: allow standardized EOF analysis

xarray-contrib · Feb 15, 2022 · 6e80f78 · 6e80f78
1 parent e9077a2
commit 6e80f78
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 19 deletions.
diff --git a/poetry.lock b/poetry.lock
diff --git a/xeofs/models/_eof_base.py b/xeofs/models/_eof_base.py
@@ -21,11 +21,6 @@ def __init__(
  if n_modes is None:
  self.n_modes = min(self.n_samples, self.n_features)
 
- # TODO: remove NaN
- # self._nan_idx = np.nan(X).any(axis=0)
-
- # TODO: normalization
-
  # TODO: weights
 
  @abstractmethod

diff --git a/xeofs/models/eof.py b/xeofs/models/eof.py
@@ -20,6 +20,9 @@ def __init__(
  self._arr_tf = _ArrayTransformer()
  self.X = self._arr_tf.fit_transform(X)
 
+ if norm:
+ self.X /= self.X.std(axis=0)
+
  super().__init__(
  X=X,
  Y=None,