Add a possibility to work with setter of mobx fields

[lacedon]

#13

I add a possibility to add setter like this:

{
  ...
  fromMobx: {
    localFieldName: {
      get() { return storeInstance.storeFieldName },
      set(value) { storeInstance.setStoreFieldName(value) }
    }
  },
  ...
}

[nighca]

Thanks for your work @lacedon .

Seems that you used vue's computed property to realize setter for fromMobx fields. To achieve this, another reactive property (__movue_${fieldKey}) is introduced. That makes it a little too complicated to understand and debug.

I have be wondering if we can realize setter without introducing vue computed property, but failed until now. What about introducing computed only when setter is configured?

Since we rarely need setter (maybe I'm wrong, but I do not like the getter/setter way), we can get clean realization in most times.

Hope for your idea.

[nighca]

Another thing I care about here: when there is no fromMobx part in the component definition, it will be better for us not to set the __movueDisposers__ field of the component. That makes normal components cleaner.

[lacedon]

I agree. I will refactor that code.

[lacedon]

Seems that you used vue's computed property to realize setter for fromMobx fields. To achieve this, another reactive property (__movue_${fieldKey}) is introduced. That makes it a little too complicated to understand and debug.

I have be wondering if we can realize setter without introducing vue computed property, but failed until now. What about introducing computed only when setter is configured?

I agree, that it's little bit complicated, but I'm not sure about debugging.
As for end user, computed property could be more useful, because they can see computed properties in vue dev tool. But vue dev tool doesn't show "just reactive" properties.

Also I think if we do that in one style it will be easier to understand code of plugin.

And beside that, if component have data property with name that's the same as reactive property there won't be any message about that. But if we use computed property Vue will throw warning about the same names. I think, logic like that should be part of Vue, not plugins.

[nighca]

I agree that computed is better for users.

There is another way that extra __movue_${fieldKey} properties can be avoided: create a new Vue instance and define all reactive properties on it (just like what vuex does), then we can use them in the computed fields of given components.

[lacedon]

Great idea!

I created a file change-detector.ts and put in it code to work with reactive properties.

[nighca]

Maybe forEach will be better here than map

[lacedon]

I agree. Fixed that.

[nighca]

👍

[nighca]

v0.1.0