Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Empty string being returned as array #307

Merged
merged 2 commits into from
Apr 7, 2024
Merged

fix: Empty string being returned as array #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8cc412
fix: Empty string being returned as array
nikcio Apr 7, 2024
667ba0f
test: Update test files
nikcio Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Nikcio.UHeadless.Base/Base/Basics/EditorsValues/Fallback/Models/BasicPropertyValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public BasicPropertyValue(CreatePropertyValue createPropertyValue) : base(create

Value = createPropertyValue.Property.Value(createPropertyValue.PublishedValueFallback, createPropertyValue.Culture, createPropertyValue.Segment, createPropertyValue.Fallback);

if (Value is IEnumerable list && !list.GetEnumerator().MoveNext())
if (Value is not string && Value is IEnumerable list && !list.GetEnumerator().MoveNext())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ New issue: Complex Conditional
BasicPropertyValue has 1 complex conditionals with 2 branches, threshold = 2

Suppress

{
Value = new List<object>();
}
Expand Down
Binary file modified src/Nikcio.UHeadless.IntegrationTests.TestProject/umbraco/Data/Sharable-Test
View file
Open in desktop
Binary file not shown.
Loading
Loading