V6/contrib #326
Closed
V6/contrib #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
-38
to
-45
| public async Task<TrackErrorStatusCodeResponse> TrackErrorStatusCodeAsync( | ||
| IResolverContext resolverContext, | ||
| [GraphQLDescription("Status code of the client error.")] int statusCode, | ||
| [GraphQLDescription("The URL that generated the client error.")] string url, | ||
| [GraphQLDescription("The time and date at which the client error was generated")] DateTime timestamp, | ||
| [GraphQLDescription("The URL from which the current URL is requested")] string? referrer) | ||
| { | ||
| ArgumentNullException.ThrowIfNull(resolverContext); |
There was a problem hiding this comment.
✅ No longer an issue: Excess Number of Function Arguments
TrackErrorStatusCodeAsync is no longer above the threshold for number of arguments
Comment on lines
-54
to
-86
| [InlineData("test-3", "https://example-site.com/not-found", "2024-05-30T14:10:20+01:00", "https://site-example.com/not-found", 404, true)] | ||
| public async Task UrlTrackerExampleQuery_TrackErrorStatusCode_Async( | ||
| string testCase, | ||
| string url, | ||
| string timeStamp, | ||
| string? referrer, | ||
| int statusCode, | ||
| bool expectSuccess) | ||
| { | ||
| var snapshotProvider = new SnapshotProvider($"{_urlTrackerExampleSnapshotPath}/TrackErrorStatusCode"); | ||
| HttpClient client = _factory.CreateClient(); | ||
|
|
||
| using var request = JsonContent.Create(new | ||
| { | ||
| query = UrlTrackerExampleQueries.TrackErrorStatusCode, | ||
| variables = new | ||
| { | ||
| url, | ||
| timeStamp, | ||
| referrer, | ||
| statusCode | ||
| } | ||
| }); | ||
|
|
||
| HttpResponseMessage response = await client.PostAsync("/graphql", request).ConfigureAwait(true); | ||
|
|
||
| string responseContent = await response.Content.ReadAsStringAsync().ConfigureAwait(true); | ||
|
|
||
| string snapshotName = $"UrlTrackerExample_TrackErrorStatusCode_{testCase}.snap"; | ||
|
|
||
| await snapshotProvider.AssertIsSnapshotEqualAsync(snapshotName, responseContent).ConfigureAwait(true); | ||
| Assert.Equal(expectSuccess, response.IsSuccessStatusCode); | ||
| } |
There was a problem hiding this comment.
✅ No longer an issue: Excess Number of Function Arguments
UrlTrackerExampleQuery_TrackErrorStatusCode_Async is no longer above the threshold for number of arguments
| @@ -257,74 +257,6 @@ ... on IMediaPickerEditorCulture { | |||
| __typename | |||
| } | |||
| } | |||
| ... on IMediaPickerLegacyEditor { | |||
There was a problem hiding this comment.
✅ Getting better: Lines of Declarations in a Single File
The lines of data declarations decreases from 3408 to 3136, threshold = 1500
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.