Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve position for native fullscreen window after exiting #562

Open
bin101 opened this issue Oct 4, 2024 · 2 comments
Open

Preserve position for native fullscreen window after exiting #562

bin101 opened this issue Oct 4, 2024 · 2 comments

Comments

@bin101
Copy link

bin101 commented Oct 4, 2024

I built a snapshot from commit 0589ac7 and noticed that when entering native fullscreen, the window is detached and when exiting native fullscreen, the window is reattached after the last focused window and does not return to the last known position.

I found this where @nikitabobko said this is the intended behaviour, but also this that at least the behaviour for hidden windows should be changed to preserve the position in the tree.

This is more of a feature request to rethink the native fullscreen behavior. At least for me, it disturbed my workflow, as I have an ultra-wide monitor with multiple browser instances in a horizontal accordion container and keep my IDE next to it on the same workspace, and switching back and forth between native fullscreen in a e.g. Youtube video completely destroys my layout.

aerospace CLI client version: 0.0.0-SNAPSHOT 0589ac7d3071042e0c17e80dd517a0bcdbf798e9
AeroSpace.app server version: 0.0.0-SNAPSHOT 0589ac7d3071042e0c17e80dd517a0bcdbf798e9
@nikitabobko
Copy link
Owner

but also #18 (comment) that at least the behaviour for hidden windows should be changed to preserve the position in the tree.

No, you're reading it wrong. Windows of hidden apps will preserve their workspace assignment. They will work in the same way as macos native fullscreen windows do right now.


As of your overall request - a particular proposal of the algorithm should be made on how to attach windows back to the tree where they were. I already briefly described the essence of the problem here #188 (comment)

@bin101
Copy link
Author

bin101 commented Oct 11, 2024

I though yabai had a solution but it didn't and I don't feel smart enough to have a complete solution for this problem.

Could it be one first step to persist the state of the tree before entering the native fullscreen and only use the current implementation if the tree cannot be restored? I mean this should only be the case if the branch containing the now native fullscreen window was modified somewhere on the way back to the root or am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants