Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Sketchybar Events #76

Closed
MatthiasGrandl opened this issue Dec 30, 2023 · 2 comments
Closed

Support for Sketchybar Events #76

MatthiasGrandl opened this issue Dec 30, 2023 · 2 comments
Milestone
0.8.0-Beta

Comments

@MatthiasGrandl
Copy link
Contributor

https://felixkratz.github.io/SketchyBar/config/events#creating-custom-events

Sketchybar uses notifications through NSDistributedNotificationCenter to support live updating of items. Would be cool if AeroSpace workspace changes would send such notifications.
@MatthiasGrandl MatthiasGrandl mentioned this issue Dec 30, 2023
Closed
@MatthiasGrandl
Copy link
Contributor Author

@nikitabobko I already implemented and tested this. I'll open a PR!

@MatthiasGrandl MatthiasGrandl mentioned this issue Jan 1, 2024
Closed
@nikitabobko nikitabobko mentioned this issue Jan 1, 2024
Closed
@nikitabobko
Copy link
Owner

nikitabobko commented Jan 1, 2024 •
edited
Loading

A follow-up is to introduce on-workspace-changed callback #87. Having NSDistributedNotificationCenter is nice, but it's Apple proprietary API and other tools might not be good at integrating with it

@nikitabobko nikitabobko added this to the 0.8.0-Beta milestone Jan 3, 2024
jakenvac pushed a commit to jakenvac/AeroSpace that referenced this issue Aug 16, 2024
@MatthiasGrandl @nikitabobko
add NSDistributedNotificationCenter for better sketchybar support
3114978 
Co-authored-by: Nikita Bobko <[email protected]>

closes nikitabobko#76
closes nikitabobko#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0-Beta
Development

Successfully merging a pull request may close this issue.

add NSDistributedNotificationCenter for better sketchybar support MatthiasGrandl/AeroSpace
2 participants
@nikitabobko @MatthiasGrandl