-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with DEFAULT_PADDING #31
Comments
In fact, that was my mistake. Will update soon today. |
Updated on latest release. |
Thank you very much! Well, that was not a real mistake, already thought you probably just committed a value for testing or something like that. Keep up the good work 👍 Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
today I stumbled about an glitch with the latest changes we made: The animations were cut off.
I checked the changes we made and found that the
animationRect
insetUpAnimation()
has had a negative value for width and height.The reason: You set a
DEFAULT_PADDING
of 25 instead of 0 what I proposed in my PR some weeks ago. My animation setup currently is only 25x25, thus the negative value.Short question: Why default to 25? I think it's better to stick to 0 and leave it up to the user to adjust that default via Code or IB.
Cheers,
Frederik
The text was updated successfully, but these errors were encountered: