Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to contribute #81

Closed
Ppjet6 opened this issue Jan 29, 2023 · 2 comments
Closed

How to contribute #81

Ppjet6 opened this issue Jan 29, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@Ppjet6
Copy link
Contributor

Ppjet6 commented Jan 29, 2023

Is your feature request related to a problem? Please describe.
I am very foreign to the latest javascript developments, and having notes on how to start making changes to the codebase would be very helpful.

I've gone as far as running npm install, npm run telling me to run vite which I found in node_modules, this provides a local web server, then I copied local.js from public that I put in the root folder (trying things..), which worked for a time but now my changes in this file aren't picked up anymore.

I have a local prosody installed, that works fine.

Describe the solution you'd like
Notes either in the README or in some other file alongside indicating how to get a local setup working and how to make changes.

@Ppjet6 Ppjet6 added the enhancement New feature or request label Jan 29, 2023
@nioc
Copy link
Owner

nioc commented Jan 29, 2023

Oups, I was sure I wrote a CONTRIBUTING.md like this one.

I will add it and also a dev dockerfile. In the meantime, here are the key points:

  1. Install prerequisite:
  • Node.js
  • npm npm install npm@latest -g
  • git clone to a folder of your choice (/var/www/xmpp-web for example)
  1. Access the frontend folder in a shell cd /var/www/xmpp-web
  2. Build the project npm install and wait for the downloads
  3. Start the vite server npm run dev
  4. Edit local.js according to your XMPP server configuration
  5. Edit the code (I suggest using VS Code)
  6. Before commit, run the linter npm run lint

@nioc nioc added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jan 29, 2023
@nioc nioc self-assigned this Jan 29, 2023
@nioc nioc added this to the 0.9.6 milestone Jan 29, 2023
@nioc nioc closed this as completed in 5c682a4 Jan 29, 2023
@nioc
Copy link
Owner

nioc commented Jan 29, 2023

@Ppjet6 I updated my contributing guide and added on this repo. Tell me if it is clear enough and easy to setup 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants