Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: integrate left-right flip detection #3313

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on May 16, 2024

  1. enh: add a node flipping the functional data

    enh: rerun registration using this flipped functional image
    celprov committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ff05251 View commit details
    Browse the repository at this point in the history
  2. enh: implement an interface to compare costs function from registrati…

    …on with original and flipped functional image to detect left-right flip
    
    enh: propagate the flip_info through the workflow so it can be integrated into the visual report
    celprov committed May 16, 2024
    Configuration menu
    Copy the full SHA
    975db16 View commit details
    Browse the repository at this point in the history
  3. enh: dedicate a line to left-right flip check in functional summary w…

    …ithin visual report
    
    enh: report costs in registration with original and flipped functional image
    celprov committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9cac594 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    a49a128 View commit details
    Browse the repository at this point in the history
  2. enh: define a flip_info output for fsl_bbr_wf because otherwise test …

    …of the workflow initialisation fails complaining this connection does not exist. The output is the dictionary with the same keys as the flip_info for the bbr_wf except the value associated with the keys are empty.
    celprov committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7a976df View commit details
    Browse the repository at this point in the history
  3. sty: ruff

    enh: point to new branch of niworkflows that implement AxisFlip
    celprov committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    4232b3a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. enh: move the transform handling within bbreg_wf in its own workflow …

    …to avoid duplicating this part of the code when additionally outputting the transform betweeen the flipped bold and the t1w.
    celprov committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    522753b View commit details
    Browse the repository at this point in the history
  2. fix: I realized that I mistakenly understood that I was flipping the …

    …T1w image when I was actually flipping the BOLD, any previous commit that states the T1w was flipped is a mistake.
    
    enh: plot the alignment between the flipped BOLD and T1w as a complement to left-right flip check through cost comparison. The plot is hidden in a drop down section.
    celprov committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    9cb9527 View commit details
    Browse the repository at this point in the history
  3. sty: ruff

    celprov committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    827db7b View commit details
    Browse the repository at this point in the history