Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Hashed SharedKey config value and environment variable #108

Open
madhogs opened this issue Sep 6, 2022 · 2 comments
Open
Labels
todo // Todo:

Comments

@madhogs
Copy link

madhogs commented Sep 6, 2022

Hi,

Would it be possible to add the option for a hashed SharedKey in the config and an environment variable.
This is simply to avoid the need to store it in plain text anywhere.
Thought this would be a nice feature, noticed something similar to this with Dashy https://dashy.to/docs/authentication/#setting-up-authentication

Thanks

@nirui
Copy link
Owner

nirui commented Sep 7, 2022

This is a good idea, and IMO this should be how SharedKey is set by default.

However, add this feature to Sshwifty without introduce a new (and more confusing) option/schema to it's current configuration file is difficult. So if you're not in a hurry, I'll mark this as TODO for now.

I will implement this feature in the next rewrite of Sshwifty which will introduce a different configuration format (not a JSON file) anyway. That will provide me a chance to completely change how SharedKey is generated and set.

@nirui nirui added the todo // Todo: label Sep 7, 2022
@madhogs
Copy link
Author

madhogs commented Sep 7, 2022

That sounds great, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo // Todo:
Projects
None yet
Development

No branches or pull requests

2 participants