Fix TempFile usage while temp dir was deleted in same process #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cannot make test running on CI, help is wanted. It seems they're running in parallel, I've tried to add |
lahma
reviewed
Jul 27, 2023
| { | ||
| dir = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), "poifiles")).FullName; | ||
| string tempDir = Path.Combine(Path.GetTempPath(), "poifiles"); | ||
| dir = Directory.CreateDirectory(tempDir).FullName; |
There was a problem hiding this comment.
CreateDirectory always called so shouldn't actually be dir be assigned tempdirs value?
There was a problem hiding this comment.
I didn't change much code, but dir variable doesn't needed at all
Bykiev
commented
Jul 27, 2023
|
|
||
| if (!Directory.Exists(dir)) | ||
| Directory.CreateDirectory(dir); | ||
|
|
||
| Random rnd = new Random(DateTime.Now.Millisecond); | ||
| Thread.Sleep(10); |
There was a problem hiding this comment.
What is the purpose of Thread.Sleep?
Merged
|
@Bykiev There is a conflict. Can you fix it? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #926