Ensure tests run linux and macOS #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On unix this search returns true for any index and any string value - as it searches for 0 characters before the null terminator. Replacing this string with a char corrects the issue and will work in the same way across mac, windows, and linux.
This was causing issues when testing on unix. Check was not being assigned a value, and resulted in a null reference exception when run. This change fixes the missing check data, and removes the use of Threads, as data is not passed in a safe manner between the calling thread and the created thread.
Without this tests fail due to lack of encoding provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few small issues with unit tests that result in tests not being able to run on Linux and macOS using dotnet core.
It would be much appreciated if you could add the
hacktoberfest-acceptedlabel to this PR. I believe that this is a valid contribution to the NPOI project, and this label will indicate this to the Hacktoberfest event.