bugfix: ExcelToHtmlConverter throw exception when cell has background… #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you change the code based on my review comment? |
|
Since I did not get any reply from committer, I have to close this PR. |
|
@tonyqus This problem has not been fixed, is there any fix plan? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug #621 ExcelToHtmlConverter.ProcessWorkbook throws Illegal IndexedColor index: 0 error on .NET Core 3.1
when Excel cell only set background color , the CellStyle.FillForegroundColor value = 0, IndexedColors.ValueOf() mehtod throw exception " Illegal IndexedColor index: 0 error".
Add IndexedColors. TryValueOf () method, which is used in ExcelToHtmlConverter class, to check ForegroundColor, when the CellStyle. FillForegroundColor value = 0, It returns NULL instead of throwing an exception.