Add correction to row height and column width obtained in SheetUtil methods #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2022 16:18
Due to copy-paste it was actually returning a number of columns.
…thods SixLabors.TextMeasurer mesures strings differnetly than System.Common.Drawing did. the corrective coefficients here are not 100% accurate either, but they make sure, that cell contents are not cut off. The coefficient's values were tweaked by testing them on sizable sample of test strings with different fonts, font sizes and string lengths (and hights in case of multy-line strings). Accuracy will vary depending on font size and font itself, but on average acuracy is improved for most cases.
|
the checks have failed due to the ')' missing issue, that was fixed in the PR before this one |
|
#940 is merged. Can you merge the latest code to your branch? |
|
@tonyqus Done |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SixLabors.TextMeasurer measures strings differently than System.Common.Drawing did. The corrective coefficients here are not 100% accurate either, but they make sure, that cell contents are not cut off. The coefficient's values were tweaked by testing them on sizable sample of test strings with different fonts, font sizes and string lengths (and heights in case of multi-line strings). Accuracy will vary depending on font size and font itself, but on average accuracy is improved for most cases.
Fix incorrect number of rows count in merged region returned by GetNumberOfRowsInMergedRegion method:
Due to copy-paste it was actually returning a number of columns.