Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to (easily) get specific nightly version #16

Closed
cab404 opened this issue May 16, 2021 · 4 comments
Closed

No way to (easily) get specific nightly version #16

cab404 opened this issue May 16, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@cab404
Copy link
Contributor

cab404 commented May 16, 2021

First of all, thanks for the project!
It's a lot nicer to use with flakes than mozilla-overlay, and saved me a lot of time!

I want a specific nightly version (for MIRAI), and the only way I can get it is via searching entire git history.
Adding tags would help, and should be easy enough to integrate into gh actions.

@figsoda figsoda added the enhancement New feature or request label May 16, 2021
@cab404
Copy link
Contributor Author

cab404 commented May 18, 2021

Other way would be storing every nightly release json. That would allow using consistent (and new) fenix versions.
@figsoda do you have any ideas about that? I would like to work on a PR.

@figsoda
Copy link
Member

figsoda commented May 18, 2021

I personally disagree on storing every nightly release because this would make the repository a lot heavier. I would prefer something like

channelOf = { channel, date, sha256 }: {
  rustc = [...],
  cargo = [...],
  [...]
  withComponents = [...],
  toolchain = [...],
  minimalToolchain = [...],
  defaultToolchain = [...],
  completeToolchain = [...],
};

@cab404
Copy link
Contributor Author

cab404 commented May 21, 2021

I personally disagree on storing every nightly release because this would make the repository a lot heavier. I would prefer something like

channelOf = { channel, date, sha256 }: {
  rustc = [...],
  cargo = [...],
  [...]
  withComponents = [...],
  toolchain = [...],
  minimalToolchain = [...],
  defaultToolchain = [...],
  completeToolchain = [...],
};

Looks fine to me as well, will work on a PR this weekend.

@figsoda figsoda closed this as completed in d2c600d Jul 3, 2021
@mschwaig
Copy link

mschwaig commented Sep 16, 2022

For those wondering why the date that

rustc --version

reports is consistently off by one, that's an upstream issue:
rust-lang/rust#51533

If you request a specific nightly from rustup, nixpkgs-mozilla or fenix rustc will confusingly report the day before as the build date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants