🔧 (configuration.json): update EndpointType to AzureDevOpsEndpoint

📝 (MigrationTools.xml): update generated documentation with new commit details ✅ (TfsWorkItemMigrationProcessorTests.cs): add SourceName and TargetName to test validation ♻️ (Processor.cs): remove redundant Telemetry.TrackException call Updating the EndpointType in configuration.json to AzureDevOpsEndpoint reflects the current naming conventions and services used. The generated documentation in MigrationTools.xml is updated to reflect the latest commit details, ensuring accuracy. Adding SourceName and TargetName in the TfsWorkItemMigrationProcessorTests.cs improves the test coverage and validation accuracy. Removing the redundant Telemetry.TrackException call in Processor.cs simplifies the error handling and logging process.
nkdAgility · Sep 15, 2024 · 5bcbf70 · 5bcbf70
1 parent a9e012b
commit 5bcbf70
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/configuration.json b/configuration.json
@@ -6,7 +6,7 @@
  "Version": "16.0",
  "Endpoints": {
  "Source": {
- "EndpointType": "TfsTeamProjectEndpoint",
+ "EndpointType": "AzureDevOpsEndpoint",
  "Collection": "https://dev.azure.com/nkdagility-preview/",
  "Project": "migrationSource1",
  "AllowCrossProjectLinking": false,
@@ -26,7 +26,7 @@
  }
  },
  "Target": {
- "EndpointType": "TfsTeamProjectEndpoint",
+ "EndpointType": "AzureDevOpsEndpoint",
  "Collection": "https://dev.azure.com/nkdagility-preview/",
  "Project": "migrationTest5",
  "TfsVersion": "AzureDevOps",

diff --git a/docs/Reference/Generated/MigrationTools.xml b/docs/Reference/Generated/MigrationTools.xml
diff --git a/...rationTools.Clients.TfsObjectModel.Tests/Processors/TfsWorkItemMigrationProcessorTests.cs b/...rationTools.Clients.TfsObjectModel.Tests/Processors/TfsWorkItemMigrationProcessorTests.cs
@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Options;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace MigrationTools.Processors.Tests
@@ -25,7 +26,10 @@ public void OptionsValidator_Valid()
  var validator = new TfsWorkItemMigrationProcessorOptionsValidator();
  var x = new TfsWorkItemMigrationProcessorOptions();
  x.WIQLQuery = "SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = @TeamProject";
- Assert.IsTrue(validator.Validate(null, x).Succeeded);
+ x.SourceName = "source";
+ x.TargetName = "target";
+ ValidateOptionsResult result = validator.Validate(null, x);
+ Assert.IsTrue(result.Succeeded);
  }
 
  }

diff --git a/src/MigrationTools/Processors/Infrastructure/Processor.cs b/src/MigrationTools/Processors/Infrastructure/Processor.cs
@@ -105,7 +105,6 @@ public void Execute()
  {
  Status = ProcessingStatus.Failed;
  ProcessorActivity.SetStatus(ActivityStatusCode.Error);
- Telemetry.TrackException(ex, ProcessorActivity.Tags);
  Log.LogCritical(ex, "Validation of your configuration failed:");
  }
  catch (ConfigurationValidationException ex)