Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: missing a std:: namespace tag #1521

Closed
moodboom opened this issue Mar 17, 2019 · 1 comment
Closed

Minor: missing a std:: namespace tag #1521

moodboom opened this issue Mar 17, 2019 · 1 comment
Assignees
@nlohmann
Labels
confirmed release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.6.0

Comments

@moodboom
Copy link

In line 12493 of single_include json.hpp, the begin() call is missing std:: namespace prefix, so if boost is installed it is ambiguous. Adding std:: fixes it.

git hash df0f7f2

Thanks!
@nlohmann nlohmann added this to the Release 3.6.0 milestone Mar 17, 2019
@nlohmann nlohmann self-assigned this Mar 17, 2019
nlohmann added a commit that referenced this issue Mar 17, 2019
@nlohmann
💚 fix CI and #1521
56f6d1d
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Mar 17, 2019
@nlohmann
Copy link
Owner

Fixed in the latest develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
confirmed release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.6.0
Development

No branches or pull requests
2 participants
@nlohmann @moodboom