Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect LLVM version number in README #1047

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fixed incorrect LLVM version number in README #1047

merged 1 commit into from
Apr 10, 2018

Conversation

jupjohn
Copy link
Contributor

@jupjohn jupjohn commented Apr 10, 2018

clang-900.0.39.2 is from LLVM 9.0.0, not 8.1.0 (as listed in the support compilers table)


Pull request checklist

None of these apply to the README.

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

clang-900.0.39.2 is from LLVM 9.0.0, not 8.1.0
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.1.3 milestone Apr 10, 2018
@nlohmann nlohmann self-assigned this Apr 10, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7f20e9d on jammehcow:patch-1 into 7c503c6 on nlohmann:develop.

@nlohmann nlohmann merged commit 29362c6 into nlohmann:develop Apr 10, 2018
@nlohmann
Copy link
Owner

Thanks!

@jupjohn jupjohn deleted the patch-1 branch April 10, 2018 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants