Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #960.
There is some refactoring in
detail/meta
, the checks we perform were too brittle (I fixed some issues in the mean time).At some point I'd like to iron out the quirks in
meta
, (e.g.is_compatible_*
traits, etc...), but this is not the goal of this PR.I will sum up the pros/cons of this PR that can be found in detail in #960:
Pros:
nlohmann::json
is now more SFINAE-correct. The library has better interoperability with other generic libraries. (Not 100% because of operator T() considered harmful #958 though)Cons:
static_assert
, instead the compiler will yell that no constructor could be used.Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmann
directory, runmake amalgamate
to create the single-header filesingle_include/nlohmann/json.hpp
. The whole process is described here.