cmake: Generate and install a pkg-config file #1701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to build mtxclient, which expects a nlohmann_json pkg-config file to exist in the system. The meson builds install a pkg-config file, but the cmake builds don't. This adds a pkg-config file to the cmake builds that is functionally equivalent to the one generated from meson. Signed-off-by: Palmer Dabbelt <[email protected]>
|
@nlohmann is this the right place to send pull requests of this sort? |
|
Thanks for the PR! The code looks good, but could you please also add a note to the README how to use the library with pkgconfig? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
state: stale
This was referenced Jul 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to build mtxclient, which expects a nlohmann_json pkg-config
file to exist in the system. The meson builds install a pkg-config
file, but the cmake builds don't. This adds a pkg-config file to the
cmake builds that is functionally equivalent to the one generated from
meson.
Signed-off-by: Palmer Dabbelt [email protected]