Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Always use SED variable #2264

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Makefile: Always use SED variable #2264

merged 1 commit into from
Jul 14, 2020

Conversation

t-b
Copy link
Contributor

@t-b t-b commented Jul 13, 2020

We need to have a proper sed, even on MacOSX. So let's use the variable
introduced in 191aa0f (:wrench: overworked maintaner targets,
2019-03-28) in more places.

@t-b
Makefile: Always use SED variable
88adffd 
We need to have a proper sed, even on MacOSX. So let's use the variable
introduced in 191aa0f (:wrench: overworked maintaner targets,
2019-03-28) in more places.
@t-b t-b requested a review from nlohmann as a code owner July 13, 2020 12:46
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88adffd on t-b:feature/use-proper-SED-in-makefile into cf74131 on nlohmann:develop.

nlohmann
nlohmann approved these changes Jul 13, 2020
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Jul 13, 2020
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 13, 2020
@nlohmann nlohmann merged commit 1a521cb into nlohmann:develop Jul 14, 2020
@nlohmann
Copy link
Owner

Thanks!

@t-b t-b deleted the feature/use-proper-SED-in-makefile branch July 14, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t-b @coveralls @nlohmann