Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine 'Publish documentation' workflow #3673

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Refine 'Publish documentation' workflow #3673

merged 3 commits into from
Aug 4, 2022

Conversation

falbrechtskirchinger
Copy link
Contributor

Refine the Publish documentation workflow:

  • Only run the workflow when files in /docs/mkdocs/ have changed.
  • Allow triggering the workflow manually. (Can't hurt, can it?)
  • Restrict the workflow to the nlohmann/json repository. I.e, don't try to publish the documentation on push to a fork.

@coveralls
Copy link

coveralls commented Aug 4, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6cd038e on falbrechtskirchinger:refine-publish-doc into 500bdc5 on nlohmann:develop.

@nlohmann nlohmann added this to the Release 3.11.2 milestone Aug 4, 2022
nlohmann
nlohmann approved these changes Aug 4, 2022
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit b13b874 into nlohmann:develop Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@falbrechtskirchinger @coveralls @nlohmann