Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'buildScmUpdated' event #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CheapDevotion
Copy link

While developing plugins for node-ci, I needed the ability to edit build files after they were checked out, but before the steps were run. To address this, I added a 'buildScmUpdated' event that is called right after a scm update is performed.

@okv
Copy link
Member

okv commented Mar 6, 2021

Hey there! Sorry for the late reply.
The event itself looks good 👍
But I think it would be better to emit it from _emitBuildUpdate function (which is called from _updateBuild ).
Could you also add some tests? (you might take a look at test/distributor/buildEvents.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants