Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node-addon-api v3.0.0 #44

Merged
merged 1 commit into from
May 30, 2021
Merged

Update to node-addon-api v3.0.0 #44

merged 1 commit into from
May 30, 2021

Conversation

joelpurra
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.414% when pulling 88b4292 on joelpurra:node-addon-api-3.0.0 into eadcf5d on node-ffi-napi:latest.

@joelpurra
Copy link
Contributor Author

Update is, from my point of view, unrelated to the previously reported node-addon-api vulnerability. Fixes #38 though.

@dennisameling
Copy link

@addaleax Any chance that this could be merged? The old node-addon-api version is causing build issues on Windows ARM64 in combination with Node 15.14.0. We currently add the following to the package.json and then it works perfectly:

  "resolutions": {
    "zkgroup/ref-napi/node-addon-api": "3.2.1",
    "zkgroup/ffi-napi/ref-napi/node-addon-api": "3.2.1",
    "zkgroup/ref-array-napi/ref-napi/node-addon-api": "3.2.1"
  },

Please let me know if I can be of any help in terms of testing etc. 👍🏼

@addaleax addaleax merged commit a777250 into node-ffi-napi:latest May 30, 2021
@addaleax
Copy link
Contributor

📦 [email protected]

@joelpurra joelpurra deleted the node-addon-api-3.0.0 branch May 30, 2021 10:45
@dennisameling
Copy link

Thank you! Much appreciated 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants