fix(pull-request.js): Update pull request send error handling

fix #567
node-gh · Sep 15, 2018 · a310da9 · a310da9
1 parent e4e1f17
commit a310da9
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/lib/cmds/pull-request.js b/lib/cmds/pull-request.js
@@ -1051,11 +1051,23 @@ PullRequest.prototype._submitHandler = function() {
  instance.submit(options.submit, function(err, pull) {
  if (err) {
  try {
- logger.error(
- "Can't submit pull request. " + JSON.parse(err.message).errors[0].message
- )
+ if (JSON.parse(err.message).errors[0].message) {
+ logger.error(
+ "Can't submit pull request. " +
+ JSON.parse(err.message).errors[0].message
+ )
+ } else {
+ throw Error
+ }
  } catch (ignore) {
- console.error(err)
+ if (err.code === 404) {
+ logger.error("Can't submit pull request. User Not Found")
+ } else {
+ logger.error(
+ "Can't submit pull request. " +
+ JSON.stringify(JSON.parse(err.message).errors[0])
+ )
+ }
  }
  return
  }