Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests and bugfix for line-after-title #29

Merged
merged 2 commits into from
Oct 7, 2018
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 5, 2018

Add tests for line-after-title.

Change line-after-title so that it does not report an error for commit messages that are a title line only.

@Trott
Copy link
Member Author

Trott commented Oct 7, 2018

Since I was explicitly added as an external contributor to this repo (probably by Evan some time back?), I'm going to assume it's OK for me to land a PR that's been approved by others. Hope that's OK. If I'm wrong, please revert!

@Trott Trott merged commit 3032b71 into nodejs:master Oct 7, 2018
@Trott
Copy link
Member Author

Trott commented Oct 7, 2018

(It would be great to get this into a release so that Travis doesn't complain about pull requests with commits that only contain a title line.)

@Trott
Copy link
Member Author

Trott commented Oct 8, 2018

@joyeecheung @evanlucas Any chance we can publish a new release so that we get rid of the false positive for contributors on Travis? Ref: nodejs/node#23339 (comment)

@joyeecheung
Copy link
Member

I forgot that I have npm collaborator access...published a new release, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants