Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-find-python on v0.10.x buildbot. #1172

Closed
wants to merge 1 commit into from
Closed

Fix test-find-python on v0.10.x buildbot. #1172

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Apr 11, 2017

Work around a v0.10.x CI issue where path.resolve() on UNIX systems
prefixes Windows paths with the current working directory.

v0.12 and up are free of this issue because they use
path.win32.resolve() which does the right thing.

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/9/

Work around a v0.10.x CI issue where path.resolve() on UNIX systems
prefixes Windows paths with the current working directory.

v0.12 and up are free of this issue because they use
path.win32.resolve() which does the right thing.
@bnoordhuis
Copy link
Member Author

Green! Can I get a LGTM?

Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gibfahn gibfahn self-assigned this Apr 25, 2017
@gibfahn
Copy link
Member

gibfahn commented Apr 25, 2017

Another CI run as the last one has disappeared off of Jenkins: https://ci.nodejs.org/job/nodegyp-test-pull-request/12/

I've confirmed that this fixes the 0.10 issue locally.

gibfahn pushed a commit that referenced this pull request Apr 25, 2017
Work around a v0.10.x CI issue where path.resolve() on UNIX systems
prefixes Windows paths with the current working directory.

v0.12 and up are free of this issue because they use
path.win32.resolve() which does the right thing.

PR-URL: #1172
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
@gibfahn
Copy link
Member

gibfahn commented Apr 25, 2017

Landed in 4980171

@gibfahn gibfahn closed this Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants