Skip to content

Commit

Permalink
lib: fix a few minor issues flagged by lgtm
Browse files Browse the repository at this point in the history
* Confusing (but correct) regex using `A-z` character range by
  accident
* Add the status argument to afterShutdown

PR-URL: #25873
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
  • Loading branch information
rneatherway authored and addaleax committed Feb 6, 2019
1 parent 353de0f commit 0b302e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -1518,7 +1518,8 @@ function streamOnPause() {
this[kHandle].readStop();
}

function afterShutdown() {
function afterShutdown(status) {
// Currently this status value is unused
this.callback();
const stream = this.handle[kOwner];
if (stream)
Expand Down
2 changes: 1 addition & 1 deletion tools/cpplint.py
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ def GetNonHeaderExtensions():

_RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]'
r'(?<!(sizeof|return))'
r'\s\*[a-zA-z_][0-9a-zA-z_]*')
r'\s\*[a-zA-Z_][0-9a-zA-Z_]*')

_regexp_compile_cache = {}

Expand Down

0 comments on commit 0b302e4

Please sign in to comment.