Skip to content

Commit

Permalink
doc: update author-ready label terms
Browse files Browse the repository at this point in the history
PR-URL: #23249
Refs: #22255
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
  • Loading branch information
vsemozhetbyt authored and targos committed Oct 7, 2018
1 parent 33e3eb4 commit 11c6745
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
9 changes: 5 additions & 4 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,11 @@ necessary.
### Author ready pull requests

A pull request that is still awaiting the minimum review time is considered
_author ready_ as soon as the CI has been started, it has at least one approval,
and it has no outstanding review comments. Please always make sure to add the
`author ready` label to the PR in that case and remove it again as soon as that
condition is not met anymore.
_author ready_ as soon as the CI has been started, it has at least two approvals
(one Collaborator approval is enough if the pull request has been open for more
than 7 days), and it has no outstanding review comments. Please always make sure
to add the `author ready` label to the PR in that case and remove it again as
soon as that condition is not met anymore.

### Handling own pull requests

Expand Down
3 changes: 2 additions & 1 deletion doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ onboarding session.
* Please add the `author-ready` label for PRs where:
* the CI has been started (not necessarily finished),
* no outstanding review comments exist and
* at least one collaborator approved the PR.
* at least two Collaborators approved the PR (one Collaborator approval is
enough if the pull request has been open for more than 7 days).

* See [Who to CC in the issue tracker][who-to-cc].
* This will come more naturally over time
Expand Down

0 comments on commit 11c6745

Please sign in to comment.