child_process: do not need to count length when maxBuffer is Infinity

PR-URL: #43822 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs · Jul 31, 2022 · 212115c · 212115c
1 parent bc376c9
commit 212115c
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -448,6 +448,11 @@ function execFile(file, args = [], options, callback) {
  child.stdout.setEncoding(encoding);
 
  child.stdout.on('data', function onChildStdout(chunk) {
+ // Do not need to count the length
+ if (options.maxBuffer === Infinity) {
+ ArrayPrototypePush(_stdout, chunk);
+ return;
+ }
  const encoding = child.stdout.readableEncoding;
  const length = encoding ?
  Buffer.byteLength(chunk, encoding) :
@@ -473,6 +478,11 @@ function execFile(file, args = [], options, callback) {
  child.stderr.setEncoding(encoding);
 
  child.stderr.on('data', function onChildStderr(chunk) {
+ // Do not need to count the length
+ if (options.maxBuffer === Infinity) {
+ ArrayPrototypePush(_stderr, chunk);
+ return;
+ }
  const encoding = child.stderr.readableEncoding;
  const length = encoding ?
  Buffer.byteLength(chunk, encoding) :
@@ -487,7 +497,7 @@ function execFile(file, args = [], options, callback) {
  ex = new ERR_CHILD_PROCESS_STDIO_MAXBUFFER('stderr');
  kill();
  } else {
- _stderr.push(chunk);
+ ArrayPrototypePush(_stderr, chunk);
  }
  });
  }