idna: use url module instead of punycode

nodejs · Sep 7, 2020 · 32d9dff · 32d9dff
1 parent e0d3b75
commit 32d9dff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/internal/idna.js b/lib/internal/idna.js
@@ -4,6 +4,6 @@ if (internalBinding('config').hasIntl) {
  const { toASCII, toUnicode } = internalBinding('icu');
  module.exports = { toASCII, toUnicode };
 } else {
- const { toASCII, toUnicode } = require('punycode');
- module.exports = { toASCII, toUnicode };
+ const { domainToASCII, domainToUnicode } = require('internal/url');
+ module.exports = { toASCII: domainToASCII, toUnicode: domainToUnicode };
 }
diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -119,7 +119,7 @@ if (!common.isMainThread) {
 if (common.hasIntl) {
  expectedModules.add('Internal Binding icu');
 } else {
- expectedModules.add('NativeModule punycode');
+ expectedModules.add('NativeModule url');
 }
 
 if (process.features.inspector) {