Skip to content

Commit

Permalink
test: add common.platformTimeout() to dgram test
Browse files Browse the repository at this point in the history
Use common.platformTimeout() to mitigate potential for CI to timeout
on slower devices.

Ref: #4937
PR-URL: #4938
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
Trott authored and rvagg committed Feb 8, 2016
1 parent 90219c3 commit 443d046
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions test/parallel/test-dgram-send-empty-buffer.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
'use strict';
var common = require('../common');

var dgram = require('dgram');
var client, timer, buf;
const common = require('../common');
const dgram = require('dgram');

if (process.platform === 'darwin') {
console.log('1..0 # Skipped: because of 17894467 Apple bug');
return;
}


client = dgram.createSocket('udp4');
const client = dgram.createSocket('udp4');

client.bind(common.PORT);

Expand All @@ -19,9 +16,9 @@ client.on('message', function(buffer, bytes) {
client.close();
});

buf = new Buffer(0);
const buf = new Buffer(0);
client.send(buf, 0, 0, common.PORT, '127.0.0.1', function(err, len) { });

timer = setTimeout(function() {
const timer = setTimeout(function() {
throw new Error('Timeout');
}, 200);
}, common.platformTimeout(200));

0 comments on commit 443d046

Please sign in to comment.