Skip to content

Commit

Permalink
build: warn for gcc versions earlier than 8.3.0
Browse files Browse the repository at this point in the history
Update the warning threshold to match the minimum supported version
of gcc. Builds can still proceed, but are not guaranteed to work.

PR-URL: #37935
Refs: #37871
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
richardlau authored and aduh95 committed Mar 28, 2021
1 parent 19ed27d commit 558d1e6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -960,8 +960,8 @@ def check_compiler(o):
('clang ' if is_clang else '', CXX, version_str))
if not ok:
warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX)
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0):
warn('C++ compiler (CXX=%s, %s) too old, need g++ 6.3.0 or clang++ 8.0.0' %
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0):
warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' %
(CXX, version_str))

ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')
Expand Down

0 comments on commit 558d1e6

Please sign in to comment.