Skip to content

Commit

Permalink
src: stop overriding deprecated V8 methods
Browse files Browse the repository at this point in the history
These methods will be removed in V8 8.1, hence we need to stop
overriding them.

PR-URL: #32116
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
backes authored and mmarchini committed Mar 18, 2020
1 parent 1cd235d commit 59eeb3b
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/node_platform.h
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,6 @@ class NodePlatform : public MultiIsolatePlatform {
void CallOnWorkerThread(std::unique_ptr<v8::Task> task) override;
void CallDelayedOnWorkerThread(std::unique_ptr<v8::Task> task,
double delay_in_seconds) override;
void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override {
UNREACHABLE();
}
void CallDelayedOnForegroundThread(v8::Isolate* isolate,
v8::Task* task,
double delay_in_seconds) override {
UNREACHABLE();
}
bool IdleTasksEnabled(v8::Isolate* isolate) override;
double MonotonicallyIncreasingTime() override;
double CurrentClockTimeMillis() override;
Expand Down

0 comments on commit 59eeb3b

Please sign in to comment.