Skip to content

Commit

Permalink
deps: cherry-pick 26b145a from upstream V8
Browse files Browse the repository at this point in the history
Original commit message:

    [api] Deprecate ExternalStringResourceBase::IsCompressible

    [email protected]

    Bug: v8:8238
    Change-Id: Ia59aefc54c2e9f4fa3348c42fb45e7fadab8ee76
    Reviewed-on: https://chromium-review.googlesource.com/c/1349231
    Reviewed-by: Yang Guo <[email protected]>
    Commit-Queue: Andreas Haas <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#57788}

Refs:

v8/v8@26b145a

PR-URL: #25148
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
sam-github committed Dec 27, 2018
1 parent eaa1544 commit 59fa7f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
14 changes: 2 additions & 12 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -2631,8 +2631,7 @@ class V8_EXPORT String : public Name {
public:
virtual ~ExternalStringResourceBase() = default;

V8_DEPRECATE_SOON("Use IsCacheable().",
virtual bool IsCompressible() const) {
V8_DEPRECATED("Use IsCacheable().", virtual bool IsCompressible() const) {
return false;
}

Expand All @@ -2641,16 +2640,7 @@ class V8_EXPORT String : public Name {
* ExternalStringResource::data() may be cached, otherwise it is not
* expected to be stable beyond the current top-level task.
*/
virtual bool IsCacheable() const {
#if __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#endif
return !IsCompressible();
#if __clang__
#pragma clang diagnostic pop
#endif
}
virtual bool IsCacheable() const { return true; }

protected:
ExternalStringResourceBase() = default;
Expand Down

0 comments on commit 59fa7f1

Please sign in to comment.