Skip to content

Commit

Permalink
src: fix typo in NODE_OPTIONS whitelist
Browse files Browse the repository at this point in the history
The whitelist of allowed cli flags that can be passed in the
NODE_OPTIONS environment variable had --trace-events-categories,
but the cli flag is actually --trace-event-categories.

PR-URL: #17369
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
evanlucas authored and MylesBorins committed Dec 12, 2017
1 parent 1cc6df2 commit 7f55f98
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/node.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3939,7 +3939,7 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
"--trace-sync-io",
"--no-force-async-hooks-checks",
"--trace-events-enabled",
"--trace-events-categories",
"--trace-event-categories",
"--track-heap-objects",
"--zero-fill-buffers",
"--v8-pool-size",
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-cli-node-options.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ expect('--track-heap-objects', 'B\n');
expect('--throw-deprecation', 'B\n');
expect('--zero-fill-buffers', 'B\n');
expect('--v8-pool-size=10', 'B\n');
expect('--trace-event-categories node', 'B\n');

if (common.hasCrypto) {
expect('--use-openssl-ca', 'B\n');
Expand Down

0 comments on commit 7f55f98

Please sign in to comment.