Skip to content

Commit

Permalink
n-api: change assert ok check to notStrictEqual.
Browse files Browse the repository at this point in the history
PR-URL: #18414
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
nbdaaron authored and MylesBorins committed Feb 21, 2018
1 parent 22093ab commit a07cd06
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions test/addons-napi/test_general/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ assert.strictEqual(test_general.testGetPrototype(baseObject),
Object.getPrototypeOf(baseObject));
assert.strictEqual(test_general.testGetPrototype(extendedObject),
Object.getPrototypeOf(extendedObject));
assert.ok(test_general.testGetPrototype(baseObject) !==
test_general.testGetPrototype(extendedObject),
'Prototypes for base and extended should be different');
// Prototypes for base and extended should be different.
assert.notStrictEqual(test_general.testGetPrototype(baseObject),
test_general.testGetPrototype(extendedObject));

// test version management functions
// expected version is currently 1
Expand Down Expand Up @@ -70,17 +70,15 @@ assert.strictEqual(test_general.derefItemWasCalled(), true,
// Assert that wrapping twice fails.
const x = {};
test_general.wrap(x);
assert.throws(function() {
test_general.wrap(x);
}, Error);
assert.throws(() => test_general.wrap(x), Error);

// Ensure that wrapping, removing the wrap, and then wrapping again works.
const y = {};
test_general.wrap(y);
test_general.removeWrap(y);
assert.doesNotThrow(function() {
test_general.wrap(y);
}, Error, 'Wrapping twice succeeds if a remove_wrap() separates the instances');
assert.doesNotThrow(() => test_general.wrap(y), Error,
'Wrapping twice succeeds if a remove_wrap()' +
' separates the instances');

// Ensure that removing a wrap and garbage collecting does not fire the
// finalize callback.
Expand Down

0 comments on commit a07cd06

Please sign in to comment.