lib,tools,test: remove custom number-isnan rule

This commit removes the custom number-isnan ESLint rule in
favor of the no-restricted-syntax rule. It also applies the
rule across the entire codebase, instead of just the test/
directory.

PR-URL: #31211
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

.eslintrc.js

@@ -244,6 +244,10 @@ module.exports = {
  selector: "CallExpression[callee.property.name='strictEqual'][arguments.0.type='Literal']:not([arguments.1.type='Literal']):not([arguments.1.type='ObjectExpression']):not([arguments.1.type='ArrayExpression']):not([arguments.1.type='UnaryExpression'])",
  message: 'The first argument should be the `actual`, not the `expected` value.',
  },
+ {
+ selector: "CallExpression[callee.name='isNaN']",
+ message: 'Use Number.isNaN() instead of the global isNaN() function.',
+ },
  ],
  /* eslint-enable max-len */
  'no-return-await': 'error',

lib/.eslintrc.yaml

@@ -63,6 +63,8 @@ rules:
  message: "Please use `require('internal/errors').hideStackFrames()` instead."
  - selector: "AssignmentExpression:matches([left.name='prepareStackTrace'], [left.property.name='prepareStackTrace'])"
  message: "Use 'overrideStackTrace' from 'lib/internal/errors.js' instead of 'Error.prepareStackTrace'."
+ - selector: "CallExpression[callee.name='isNaN']"
+ message: "Use NumberIsNaN() primordial instead of the global isNaN() function."
  # Custom rules in tools/eslint-rules
  node-core/lowercase-name-for-primitive: error
  node-core/non-ascii-character: error

test/.eslintrc.yaml

@@ -18,7 +18,6 @@ rules:
  node-core/crypto-check: error
  node-core/eslint-check: error
  node-core/inspector-check: error
- node-core/number-isnan: error
  ## common module is mandatory in tests
  node-core/required-modules:
  - error

test/root.status

@@ -34,7 +34,6 @@ parallel/test-eslint-eslint-check: SLOW
 parallel/test-eslint-inspector-check: SLOW
 parallel/test-eslint-lowercase-name-for-primitive: SLOW
 parallel/test-eslint-no-unescaped-regexp-dot: SLOW
-parallel/test-eslint-number-isnan: SLOW
 parallel/test-eslint-prefer-assert-iferror: SLOW
 parallel/test-eslint-prefer-assert-methods: SLOW
 parallel/test-eslint-prefer-common-mustnotcall: SLOW