tools: cleanup getnodeversion.py for readability

PR-URL: #29648 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Sep 25, 2019 · b7488c2 · b7488c2
1 parent 5d60adf
commit b7488c2
Showing 1 changed file with 15 additions and 15 deletions.
diff --git a/tools/getnodeversion.py b/tools/getnodeversion.py
@@ -1,21 +1,21 @@
 from __future__ import print_function
 import os
-import re
 
-node_version_h = os.path.join(
- os.path.dirname(__file__),
- '..',
- 'src',
- 'node_version.h')
 
-f = open(node_version_h)
+def get_major_minor_patch(text):
+ for line in text.splitlines():
+ if line.startswith('#define NODE_MAJOR_VERSION'):
+ major = line.split()[2]
+ elif line.startswith('#define NODE_MINOR_VERSION'):
+ minor = line.split()[2]
+ elif line.startswith('#define NODE_PATCH_VERSION'):
+ patch = line.split()[2]
+ return major, minor, patch
 
-for line in f:
- if re.match('^#define NODE_MAJOR_VERSION', line):
- major = line.split()[2]
- if re.match('^#define NODE_MINOR_VERSION', line):
- minor = line.split()[2]
- if re.match('^#define NODE_PATCH_VERSION', line):
- patch = line.split()[2]
 
-print('%(major)s.%(minor)s.%(patch)s'% locals())
+node_version_h = os.path.join(os.path.dirname(__file__),
+ '..',
+ 'src',
+ 'node_version.h')
+with open(node_version_h) as in_file:
+ print('.'.join(get_major_minor_patch(in_file.read())))