lib: make fetch sync and return a Promise

update test PR-URL: #49936 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
nodejs · Sep 30, 2023 · fa250fd · fa250fd
1 parent 6c9625d
commit fa250fd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js
@@ -292,7 +292,8 @@ function setupUndici() {
  }
 
  if (!getOptionValue('--no-experimental-fetch')) {
- async function fetch(input, init = undefined) {
+ // Fetch is meant to return a Promise, but not be async.
+ function fetch(input, init = undefined) {
  return lazyUndici().fetch(input, init);
  }
 

diff --git a/test/parallel/test-fetch.mjs b/test/parallel/test-fetch.mjs
@@ -10,6 +10,14 @@ assert.strictEqual(typeof globalThis.Headers, 'function');
 assert.strictEqual(typeof globalThis.Request, 'function');
 assert.strictEqual(typeof globalThis.Response, 'function');
 
+{
+ const asyncFunction = async function() {}.constructor;
+
+ assert.ok(!(fetch instanceof asyncFunction));
+ assert.notStrictEqual(Reflect.getPrototypeOf(fetch), Reflect.getPrototypeOf(async function() {}));
+ assert.strictEqual(Reflect.getPrototypeOf(fetch), Reflect.getPrototypeOf(function() {}));
+}
+
 const server = http.createServer(common.mustCall((req, res) => {
  res.end('Hello world');
 }));