New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fg(1) in readline's page is broken link #11492

Closed

hiroppy opened this issue Feb 22, 2017 · 1 comment

Labels

Member

hiroppy commented Feb 22, 2017 •

edited

Loading

Version: N/A
Platform: N/A
Subsystem: doc

This page is 404 now.

disputed point: https://nodejs.org/dist/latest-v7.x/docs/api/readline.html#readline_event_sigcont

hiroppy added the doc label

mscdex added the good first issue label

Contributor

Fishrock123 commented Feb 22, 2017

karanjthakkar added a commit to karanjthakkar/node that referenced this issue


docs: Change broken fg(1) links to fg(1p)

c0429d1

The fg(1) links in the readline docs have moved
from `http://man7.org/linux/man-pages/man1/fg.1.html`
to `http://man7.org/linux/man-pages/man1/fg.1p.html`.
It also modifies the regex for replacing man page links
in docs by allowing optional character after number.
eg: fg(1) and fg(1p) will both be now parsed and replaced.

Fixes: nodejs#11492

addaleax removed the good first issue label

addaleax closed this as completed in

6ae159f

addaleax pushed a commit that referenced this issue


doc: change broken fg(1) links to fg(1p)

47034e1

The fg(1) links in the readline docs have moved
from `http://man7.org/linux/man-pages/man1/fg.1.html`
to `http://man7.org/linux/man-pages/man1/fg.1p.html`.
It also modifies the regex for replacing man page links
in docs by allowing optional character after number.
eg: fg(1) and fg(1p) will both be now parsed and replaced.

Fixes: #11492
PR-URL: #11504
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment