Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILDING.md references p. 60 of a 40 page security policy document #17536

Closed
rob3c opened this issue Dec 7, 2017 · 4 comments
Closed

BUILDING.md references p. 60 of a 40 page security policy document #17536

rob3c opened this issue Dec 7, 2017 · 4 comments
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@rob3c
Copy link

rob3c commented Dec 7, 2017

  • Version: N/A
  • Platform: N/A
  • Subsystem: N/A

The current BUILDING.md instruction page in master on building node with FIPS compliant OpenSSL says:
See the security policy page 60 for more details.
Unfortunately, the current security policy pdf at the link only has 40 pages, so it's unclear what is being referenced.

@addaleax addaleax added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. openssl Issues and PRs related to the OpenSSL dependency. labels Dec 7, 2017
@addaleax
Copy link
Member

addaleax commented Dec 7, 2017

/cc @nodejs/crypto

@Trott
Copy link
Member

Trott commented Dec 7, 2017

The phrase "validated module" does not appear in the PDF. I'll open a PR to remove the entire sentence, as the policy is linked to later in the paragraph anyway.

@bnoordhuis
Copy link
Member

Pinging @mhdawson, looks like you added that in #2278.

@Trott
Copy link
Member

Trott commented Dec 7, 2017

PR to update text: #17538

@Trott Trott closed this as completed in 4426d75 Dec 10, 2017
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
MylesBorins pushed a commit that referenced this issue Dec 12, 2017
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
gibfahn pushed a commit that referenced this issue Dec 20, 2017
PR-URL: #17538
Fixes: #17536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants