-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: etw/perf/lttng/etc multi-isolate support #18074
Comments
I think this line and next one (which set callbacks to isolate) should not depends on |
@bnoordhuis This should remain open, yes? If so, is there someone particularly well-suited to try to move it forward? @nodejs/embedders maybe? |
Yes, it's still an issue. I don't have suggestions for volunteers but they're more than welcome. |
I think this issue has become obsolete after the removal of dtrace and etw in #43652 (and lttng and perfctr back in 2018.) I'll go ahead and close it. |
Continuing from nodejs/help#1031:
src/node_counters.cc
and its ilk need to have their initialization split out into a per-isolate and per-context step for embedding to work with them. Some thoughts:node.js won't know if initialization already happened if the isolate is created by the embedder, unless extra bookkeeping is added. Could hang off
MultiIsolatePlatform::RegisterIsolate()
- or could it?the tracing code itself isn't multi-isolate ready in the slightest, it's all globals that need to move to
IsolateData
andEnvironment
some tracing flavors have (possibly inevitable) process-global state that should be protected by a
uv_once_t
ornode::Mutex
.The text was updated successfully, but these errors were encountered: