Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: parallel/test-dgram-broadcast-multi-process assumes unfiltered broadcast traffic #219

Closed
bnoordhuis opened this issue Dec 30, 2014 · 1 comment
Closed

test: parallel/test-dgram-broadcast-multi-process assumes unfiltered broadcast traffic #219

bnoordhuis opened this issue Dec 30, 2014 · 1 comment

Comments

@bnoordhuis
Copy link
Member

The test fails on systems with sane firewall/routing rules:

=== release test-dgram-broadcast-multi-process ===                             
Path: parallel/test-dgram-broadcast-multi-process
[PARENT] sent 'First message to send' to 255.255.255.255:12446
[PARENT] sent 'Second message to send' to 255.255.255.255:12446
[PARENT] sent 'Third message to send' to 255.255.255.255:12446
[PARENT] sent 'Fourth message to send' to 255.255.255.255:12446
[PARENT] sendSocket closed
[PARENT] Responses were not received within 5000 ms.
[PARENT] Fail

Not sure what to do. The test is useful and I don't want to scrap it but it makes a bad assumption. Maybe change it to use loopback instead of the first non-local interface?
@bnoordhuis bnoordhuis mentioned this issue Dec 30, 2014
Closed
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Jan 6, 2015
@bnoordhuis
test: don't assume broadcast traffic is unfiltered
52e600a 
parallel/test-dgram-broadcast-multi-process assumes non-local broadcast
traffic is unfiltered, an assumption that fails with, for example, the
default Fedora firewall rules.  Use a loopback interface instead.

Fixes: nodejs#219
PR-URL: nodejs#220
Reviewed-By: Fedor Indutny <[email protected]>
@bnoordhuis
Copy link
Member Author

Closing, fixed as of 52e600a.

@snyk-bot snyk-bot mentioned this issue Feb 12, 2022
Open
@RoeeOren RoeeOren mentioned this issue Nov 30, 2023
Open
@timzwit timzwit mentioned this issue Nov 30, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this issue Nov 30, 2023
Open
@137717unity 137717unity mentioned this issue Nov 30, 2023
Open
@molllyn1 molllyn1 mentioned this issue Nov 30, 2023
Open
@awaisab172 awaisab172 mentioned this issue Nov 30, 2023
Open
@sirinartk sirinartk mentioned this issue Dec 1, 2023
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Dec 1, 2023
Open
@adamlaska adamlaska mentioned this issue Dec 1, 2023
Open
@wedataintelligence wedataintelligence mentioned this issue Dec 1, 2023
Open
@adamlaska adamlaska mentioned this issue Dec 1, 2023
Open
@karencapiiro karencapiiro mentioned this issue Feb 11, 2024
Open
@dannybrown13 dannybrown13 mentioned this issue Feb 11, 2024
Open
@ZRDK ZRDK mentioned this issue Feb 11, 2024
Open
@smclinden smclinden mentioned this issue Feb 11, 2024
Open
@dannybrown13 dannybrown13 mentioned this issue Feb 11, 2024
Open
@ZRDK ZRDK mentioned this issue Feb 11, 2024
Open
@verdinjoshua1982 verdinjoshua1982 mentioned this issue Feb 11, 2024
Open
@ryan-ally ryan-ally mentioned this issue Feb 11, 2024
Open
@pratapadi pratapadi mentioned this issue Feb 11, 2024
Open
@jen801 jen801 mentioned this issue Feb 11, 2024
Open
@xaiksan1 xaiksan1 mentioned this issue Feb 11, 2024
Open
@BryanLaura BryanLaura mentioned this issue Feb 11, 2024
Open
@baby636 baby636 mentioned this issue Feb 11, 2024
Open
@Megoy-Tambayan Megoy-Tambayan mentioned this issue Feb 11, 2024
Open
@amacsnyk amacsnyk mentioned this issue Feb 11, 2024
Open
@dannybrown13 dannybrown13 mentioned this issue Feb 11, 2024
Open
@jj-crypto jj-crypto mentioned this issue Feb 11, 2024
Open
@PinkDiamond1 PinkDiamond1 mentioned this issue Feb 11, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Feb 11, 2024
Open
@mrod0101 mrod0101 mentioned this issue Feb 11, 2024
Open
@yotamselementor yotamselementor mentioned this issue Feb 11, 2024
Open
This was referenced Feb 11, 2024
Open
Open
This was referenced Feb 11, 2024
Open
Open
@jefeaguila jefeaguila mentioned this issue Feb 11, 2024
Open
@ZRDK ZRDK mentioned this issue Feb 11, 2024
Open
@thisguy726 thisguy726 mentioned this issue Feb 11, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Feb 11, 2024
Open
@kaocher82 kaocher82 mentioned this issue Feb 11, 2024
Open
@karencapiiro karencapiiro mentioned this issue Feb 11, 2024
Open
@Supermajestcd Supermajestcd mentioned this issue Feb 12, 2024
Open
@MatheusKael MatheusKael mentioned this issue Feb 12, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Feb 12, 2024
Open
@myvali998 myvali998 mentioned this issue Feb 12, 2024
Open
@MrBrain295 MrBrain295 mentioned this issue Feb 12, 2024
Open
@nicholaschoi168 nicholaschoi168 mentioned this issue Feb 12, 2024
Open
@chrismilleruk chrismilleruk mentioned this issue Feb 12, 2024
Open
@JoanKalanzi1 JoanKalanzi1 mentioned this issue Feb 12, 2024
Open
@BryanLaura BryanLaura mentioned this issue Feb 12, 2024
Open
@jj-crypto jj-crypto mentioned this issue Feb 12, 2024
Open
@Supermajestcd Supermajestcd mentioned this issue Feb 12, 2024
Open
@MaxMood96 MaxMood96 mentioned this issue Feb 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnoordhuis