-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: investigate "incorporating feedback in your pull request" #23702
Comments
Example: #23701 (comment) |
Example2: https:/nodejs/node/pull/22079/files#r225699740 IMHO it's a very nice feature for reviewers who are willing to make the extra effort. |
I believe there's a balance to strike here. IMHO our contribution guide should focus on the things that are specific to work in this repo. While points that require general git and GitHub literacy should be referred to better guides. Such as the new https://lab.github.com/ |
A doubt: technically, any Collaborator can assign themselves to a PR and accept an own proposed change. This can alleviate nit addressing for the PR author, but also can be felt like a bit arbitrarily thing. |
New GitHub feature:
https://help.github.com/articles/incorporating-feedback-in-your-pull-request/#applying-a-suggested-change
This can simplify nits addressing. We may need to update our contributing guides (including how-to steps to sync local branches with remote changes if needed).
The text was updated successfully, but these errors were encountered: